interesting... for me JetBrains Mono won, which is the one I already use. But I discovered Atkinson Hyperlegible, which looks awesome for reading books. I guess I have a minor reading issue that I wasn't aware of!
they tried to do something with remembering "how you left things" between sessions, and even when disabled things are still weird...
Also some power management related hooks are not working as well as before. Like if you put the computer to sleep at night, and wake it up in the morning, the automatic dark-to-light theme switch doesn't trigger. at least not always.
I regularly review code that is way more complicated that it should.
The last few days I was going back and forth on reviews on a function that had originally cyclomatic complexity of 23. Eventually I got it down to 8, but I had to call him into a pair programming session and show him how the complexity could be reduced.
Someone giving work like that should be either junior enough that there is potential for training them, so your time investment is worth it, or managed out.
Or it didn't really matter that the function was complex if the structure of what's surrounding it was robust and testable; just let it be a refactor or bug ticket later.
I know the aggravation of getting a hairball of code to review, but I often hold my nose. At least find a better reason to send it back, like a specific bug.
If you're sure cyclomatic complexity should be minimized, I think you should put such rules in a pre-commit hook or something that runs before a reviewer ever sees the code. You should only have to help with that if someone can't figure out how to make it pass.
If you're not willing or politically able to implement that, you might be wasting time on your personal taste that the team doesn't agree with. Personally I'm pretty skeptical of cyclomatic complexity's usefulness as a metric.
I just used it here to approximately convey the scale.
the original function was full of mutable state (not required), full of special cases (not required), full of extra return statements (not required). Also had some private helper methods that were mocked in the tests (!!!).
All of this just for a "pure" function. Just immutable object in - immutable object out.
I always approve a change with comments for nits that are optional to address. I only hold back approval if there is a legitimate flaw of some sort. Generally this leads to small changes almost always getting approved on the first shot, but larger changes needing at least one back and forth. AI code review tools make it much easier to spot legitimate problems these days.
I'm on the phone now, but you should be able to already do it. install the Kagi translate browser extension, and use it to do this. I will try it myself in a few hours xD
we’re talking about different things. there’s meritocratic fairness where producers are paid fairly for their work, and there’s a functioning economy, where there are simply enough economic opportunities to sustain established norms of commercial participation by the broad population.
Claude Code is actually far from the best harness for Claude, ironically...
JetBrains' AI Assistant with Claude Agent is a much better harness for Claude.
reply